BugFix: cli stringSlice bug #11166
Merged
BugFix: cli stringSlice bug #11166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reverting
reverting
rolling back
rolling back
reverting changes
cmd/validator/flags/flags.go
Outdated
| @@ -349,7 +349,6 @@ var ( | |||
| EnableBuilderFlag = &cli.BoolFlag{ | |||
| Name: "enable-builder", | |||
| Usage: "Enables Builder validator registration APIs for the validator client to update settings such as fee recipient and gas limit. Note* this flag is not required if using proposer settings config file", | |||
| Value: false, | |||
There was a problem hiding this comment.
Yes, I found out that default values override configs, this is perhaps an issue through out the cli flags but in particular, I tested thsi one and realized that if you use enable-builder in the config file when it has a starting value (false) the config file does not override this value.
Co-authored-by: Preston Van Loon <preston@prysmaticlabs.com>
rauljordan
reviewed
Aug 8, 2022
rauljordan
approved these changes
Aug 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
related
urfave/cli#1197
#11009
What does this PR do? Why is it needed?
string slice flags do not support the
IsSetfunction when using theconfig-fileflag which feeds flags and their values via a yaml or json file.Which issues(s) does this PR fix?