Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mainnet merge epoch and ttd #11207

Merged
merged 26 commits into from
Aug 17, 2022
Merged

Add mainnet merge epoch and ttd #11207

merged 26 commits into from
Aug 17, 2022

Conversation

terencechain
Copy link
Member

@terencechain terencechain commented Aug 12, 2022

Added numbers for the Bellatrix epoch and TTD as per ethereum/consensus-specs#2969
Updated spec tests to rc2

Wen merge 🐼

@terencechain terencechain self-assigned this Aug 12, 2022
@terencechain terencechain requested a review from a team as a code owner August 12, 2022 01:57
@terencechain terencechain changed the title Add tentative mainnet merge epoch and ttd Add mainnet merge epoch and ttd Aug 16, 2022
@terencechain terencechain added the Ready For Review A pull request ready for code review label Aug 16, 2022
// Placeholder for the merge epoch until it is decided
mainnetBellatrixForkEpoch = math.MaxUint64
// Bellatrix Fork Epoch for mainnet config.
mainnetBellatrixForkEpoch = 144896 // Sept 6, 2022, 11:34:47am UTC
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks out. Did

genesis_time=1606824023
bellatrix_fork_epoch=144896
seconds_since_genesis=bellatrix_fork_epoch3212
genesis_time+seconds_since_genesis=1662464087

Put it into a unix converter and got
Screen Shot 2022-08-17 at 11 15 15 AM

Copy link
Contributor

@rauljordan rauljordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed the TTD and epoch according to spec. Everything checks out! Will need someone else to also approve diligently before merging

@prylabs-bulldozer prylabs-bulldozer bot merged commit dfa400d into develop Aug 17, 2022
@delete-merged-branch delete-merged-branch bot deleted the merge-mainnet branch August 17, 2022 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review A pull request ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants