Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc builder fixes #11228

Merged
merged 5 commits into from
Aug 16, 2022
Merged

Misc builder fixes #11228

merged 5 commits into from
Aug 16, 2022

Conversation

terencechain
Copy link
Member

Fixes a few typos and bugs from #11109

  • The circuit breaker flags were not added to the group, so it was undefined
  • Change defaults from 4, 6 to 3, 8 to be more prudent. 6 slots per epoch can easily be missed with a descent pool
  • Fixed warning log to display the correct diff for totalMissed
  • Updated a few variable names

@terencechain terencechain added Ready For Review A pull request ready for code review OK to merge Builder PR or issue that supports builder related work labels Aug 16, 2022
@terencechain terencechain self-assigned this Aug 16, 2022
@terencechain terencechain requested a review from a team as a code owner August 16, 2022 17:26
@prylabs-bulldozer prylabs-bulldozer bot merged commit 8d3f474 into develop Aug 16, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix-builder-typos branch August 16, 2022 19:10
@come-maiz come-maiz mentioned this pull request Sep 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rauljordan rauljordan rauljordan approved these changes

@rkapka rkapka Awaiting requested review from rkapka rkapka is a code owner automatically assigned from prysmaticlabs/core-team

@nisdas nisdas Awaiting requested review from nisdas nisdas is a code owner automatically assigned from prysmaticlabs/core-team

Assignees

@terencechain terencechain

Labels
Builder PR or issue that supports builder related work Ready For Review A pull request ready for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@terencechain @rauljordan