Deprecate native state flag #11268
Merged
Deprecate native state flag #11268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 254ab623dde08ae8886b152facdbbd8889ed79db)
rkapka
changed the title
# Conflicts: # config/features/config.go
This reverts commit b03d97a.
rkapka
commented
Sep 8, 2022
Comment on lines
+190
to
200
| go_test( | ||
| name = "go_mainnet_test", | ||
| timeout = "moderate", | ||
| srcs = [ | ||
| "attester_mainnet_test.go", | ||
| "server_mainnet_test.go", | ||
| "status_mainnet_test.go", | ||
| ], | ||
| embed = [":go_default_library"], | ||
| deps = common_deps, | ||
| ) |
There was a problem hiding this comment.
Some tests need to run using mainnet config. I separated these tests out to new mainnet files (e.g. attester_mainnet_test.go) and put them under a new rule.
# Conflicts: # config/features/deprecated_flags.go
rkapka
changed the title
prestonvanloon
approved these changes
Sep 13, 2022
rauljordan
approved these changes
Sep 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Cleanup
What does this PR do? Why is it needed?
--disable-native-stateflag and removes the associated featureInitializeFromProto, which return a native state, which makes a mess in these tests. Proto state is to be removed anyway in a later PR.Which issues(s) does this PR fix?
Fixes #10231