Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle Deprecated Flags Correctly #11276

Merged
merged 1 commit into from
Aug 20, 2022
Merged

Handle Deprecated Flags Correctly #11276

merged 1 commit into from
Aug 20, 2022

Conversation

nisdas
Copy link
Member

@nisdas nisdas commented Aug 20, 2022

What type of PR is this?

V3 Fix

What does this PR do? Why is it needed?

This gives users appropriate notice before completely removing a flag.

Which issues(s) does this PR fix?

N.A

Other notes for review

@nisdas nisdas requested a review from a team as a code owner August 20, 2022 03:56
@prylabs-bulldozer prylabs-bulldozer bot merged commit b787fd8 into develop Aug 20, 2022
@delete-merged-branch delete-merged-branch bot deleted the handleDeprecatedFlags branch August 20, 2022 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prestonvanloon prestonvanloon prestonvanloon approved these changes

@rkapka rkapka Awaiting requested review from rkapka rkapka is a code owner automatically assigned from prysmaticlabs/core-team

@james-prysm james-prysm Awaiting requested review from james-prysm james-prysm is a code owner automatically assigned from prysmaticlabs/core-team

@symbolpunk symbolpunk Awaiting requested review from symbolpunk symbolpunk is a code owner automatically assigned from prysmaticlabs/core-team

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nisdas @prestonvanloon