-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvement to Fee Recipient UX #11307
Conversation
Co-authored-by: Radosław Kapka <rkapka@wp.pl>
Co-authored-by: Radosław Kapka <rkapka@wp.pl>
Co-authored-by: Radosław Kapka <rkapka@wp.pl>
Co-authored-by: Radosław Kapka <rkapka@wp.pl>
Co-authored-by: Radosław Kapka <rkapka@wp.pl>
return ðpb.FeeRecipientByPubKeyResponse{ | ||
FeeRecipient: params.BeaconConfig().DefaultFeeRecipient.Bytes(), | ||
}, nil |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is rather dangerous, and we shouldn't skip out on the error and just default to burn address.
The caller should be able to handle the error with a switch statement
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is rather dangerous, and we shouldn't skip out on the error and just default to burn address.
The caller should be able to handle the error with a switch statemen
rotsen11
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll handle this better
What type of PR is this?
Feature
What does this PR do? Why is it needed?
Experimental UX improvements for fee recipient / validator registry. currently, the proposer settings update is required from the validator client either through flags
--suggested-fee-recipient
or--proposer-settings-file
or url. this is a redundant experience for users who have set the suggested-fee-recipient on the beacon node and would like to not have to specify this again on the validator client. This pr looks to address this in the following way--enable-builder
flag will add to the proposer settings file if used together and the proposer settings file has builder options empty.related issues
#11322
#10720 - will not be addressed in this PR but a separate PR
gas_limit persistence through API is not addressed in this PR
note: extra UX improvements