Builder: filter header with 0 bid and empty tx root #11313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
added
Ready For Review
Builder
james-prysm
reviewed
Aug 25, 2022
| @@ -120,6 +123,22 @@ func (vs *Server) getPayloadHeaderFromBuilder(ctx context.Context, slot types.Sl | |||
| if err != nil { | |||
| return nil, err | |||
| } | |||
|
|
|||
| v := bid.Message.Value | |||
There was a problem hiding this comment.
is it possible to get a message without a value here? if it's external it might be nil maybe safer for a check here
There was a problem hiding this comment.
Good point, thanks!
james-prysm
approved these changes
Aug 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes validator checking outsourced payloader more strict. It filters out headers with bid amount 0 and an empty tx root. Overall this is a good thing to make validators more defensive when outsourcing block construction