Report depth and distance on reorgs #11315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -111,8 +112,9 @@ func (s *Service) saveHead(ctx context.Context, newHeadRoot [32]byte, headBlock | |||
| "oldSlot": fmt.Sprintf("%d", headSlot), | |||
| "oldRoot": fmt.Sprintf("%#x", oldHeadRoot), | |||
| "commonAncestorRoot": fmt.Sprintf("%#x", commonRoot), | |||
| "distance": headSlot + newHeadSlot - 2*forkSlot, | |||
There was a problem hiding this comment.
do we need to subtract 1?
Shouldn't the reorg distance for the below be 2?
99 - 100
\- 101
There was a problem hiding this comment.
I would say that's 3, but I'm happy to subtract any constant, since it won't make the metric change in any meaning.
There was a problem hiding this comment.
I dont mind it, you can choose
terencechain
approved these changes
Aug 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the signature of
CommonAncestorRootto return also the Slot of the common ancestor and uses this to report useful metrics on chain reorgs.