Accept attestations when node is optimistic #11319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potuz
previously approved these changes
Aug 25, 2022
Good point. Added! |
potuz
previously approved these changes
Aug 25, 2022
terencechain
commented
Aug 25, 2022
| @@ -588,7 +588,7 @@ func TestValidateSyncCommitteeMessage_Optimistic(t *testing.T) { | |||
| Topic: &topic, | |||
| }, | |||
| } | |||
| res, err := r.validateCommitteeIndexBeaconAttestation(ctx, "foobar", msg) | |||
| res, err := r.validateSyncCommitteeMessage(ctx, "foobar", msg) | |||
There was a problem hiding this comment.
These tests are bad to begin with. TestValidateSyncCommitteeMessage_Optimistic is calling validateCommitteeIndexBeaconAttestation. I fixed it here but they will be removed in #11320
potuz
approved these changes
Aug 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It doesn't make sense why a node would stop accepting attestations over the wire under optimistic mode. The node should account for these attestations in fork choice. I understand that a node should not perform duties under optimistic mode but this is very different than performing duties