Support passing of headers to all Engine API calls #11330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkapka
reviewed
Aug 27, 2022
cmd/beacon-chain/flags/base.go
Outdated
| ExecutionEngineHeaders = &cli.StringFlag{ | ||
| Name: "execution-headers", | ||
| Usage: "A comma separated list of key value pairs to pass as HTTP headers for all execution " + | ||
| "client calls. Example: --execution-headers=key=value", |
There was a problem hiding this comment.
Can the example have 2 headers please?
rauljordan
approved these changes
Aug 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
Adds a Beacon Node CLI flag
--execution-headersto allow setting of HTTP headers on all execution engine API calls. Implementation is by and large similar to that of--grpc-headerson the validator.Which issues(s) does this PR fix?
Fixes #11149
Other notes for review