Performance Metrics for Prysm #11377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauljordan
commented
Aug 31, 2022
| @@ -253,16 +255,17 @@ func (s *Service) validateBeaconBlock(ctx context.Context, blk interfaces.Signed | |||
|
|
|||
| // validateBellatrixBeaconBlock validates the block for the Bellatrix fork. | |||
| // spec code: | |||
| // If the execution is enabled for the block -- i.e. is_execution_enabled(state, block.body) then validate the following: | |||
rauljordan
changed the title
nisdas
reviewed
Aug 31, 2022
nisdas
reviewed
Sep 1, 2022
nisdas
reviewed
Sep 1, 2022
nisdas
reviewed
Sep 1, 2022
nisdas
reviewed
Sep 1, 2022
| @@ -75,8 +77,11 @@ func (s *Service) validateAggregateAndProof(ctx context.Context, pid peer.ID, ms | |||
|
|
|||
| // Attestation's slot is within ATTESTATION_PROPAGATION_SLOT_RANGE and early attestation | |||
| // processing tolerance. | |||
| if err := helpers.ValidateAttestationTime(m.Message.Aggregate.Data.Slot, s.cfg.chain.GenesisTime(), | |||
| earlyAttestationProcessingTolerance); err != nil { | |||
| if err := helpers.ValidateAttestationTime( | |||
There was a problem hiding this comment.
Not sure why github is showing a diff here, did anything change ?
There was a problem hiding this comment.
Yeah split up the lines
nisdas
reviewed
Sep 1, 2022
| @@ -114,6 +120,8 @@ func (s *Service) validateAggregateAndProof(ctx context.Context, pid peer.ID, ms | |||
|
|
|||
| msg.ValidatorData = m | |||
|
|
|||
| aggregateAttestationVerificationGossipSummary.Observe(float64(prysmTime.Since(receivedTime).Milliseconds())) | |||
There was a problem hiding this comment.
This can be quite noisy, we receive a lot of aggregates per slot. Doing a time duration measurement might be pretty noisy
nisdas
reviewed
Sep 1, 2022
| @@ -164,6 +168,8 @@ func (s *Service) validateCommitteeIndexBeaconAttestation(ctx context.Context, p | |||
|
|
|||
| msg.ValidatorData = att | |||
|
|
|||
| unaggregatedAttestationVerificationGossipSummary.Observe(float64(prysmTime.Since(receivedTime).Milliseconds())) | |||
nisdas
previously approved these changes
Sep 1, 2022
nisdas
approved these changes
Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? Why is it needed?
This PR introduces new metrics to track performance and errors from common operations such as block processing and gossip verification for blocks and attestations. Although we already track gossip verification errors in total via metrics, this PR adds more granular error counters for attestation verification.
Which issues(s) does this PR fix?
Part of #11367