Metrics: capture reorg distances and depths #11435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is a gauge an appropriate choice for reorgs? Shouldn't it be a histogram? |
|
How do you plan to use these metrics? |
I think gauge is more appropriate than histogram. I want to use it like this: Similar to attestations in pool:
|
beacon-chain/blockchain/metrics.go
Outdated
Comment on lines
205
to
212
| Help: "Captures distance of reorgs", | ||
| Buckets: []float64{1, 2, 4, 8, 16, 32, 64}, | ||
| }, | ||
| ) | ||
| reorgDepth = promauto.NewHistogram( | ||
| prometheus.HistogramOpts{ | ||
| Name: "reorg_depth", | ||
| Help: "Captures depth of reorgs", |
There was a problem hiding this comment.
Could you please add some details to the help text? I.e. what does depth / distance mean?
There was a problem hiding this comment.
Could you please add some details to the help text? I.e. what does depth / distance mean?
Yep. Done
rauljordan
approved these changes
Sep 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? Why is it needed?
This PR captures reorg depth and reorg distance metrics. We'll like to monitor reorg and distance and depths using metrics.
Distance is say you reorg x to y, how many steps it took to get from x to y. Depth is say how many steps it takes to get to a common ancestor
Which issues(s) does this PR fix?
N/A
Other notes for review
Gauge wasn't picked because of the inaccurate count. It depends on the sample rate of Prometheus. If Prometheus is down for a minute and two reorgs happen, we'll likely not be able to capture them all. Histogram seems like the best option