Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unwanted wrapper of GRPC status error #11486

Merged
merged 3 commits into from
Sep 23, 2022
Merged

Remove unwanted wrapper of GRPC status error #11486

merged 3 commits into from
Sep 23, 2022

Conversation

yierx
Copy link
Contributor

@yierx yierx commented Sep 22, 2022

fix this issue #11472

@yierx yierx requested a review from a team as a code owner September 22, 2022 07:36
@prestonvanloon
Copy link
Member

@kasey Could you take a look at this PR please? The error wrapping was introduced in #10384.
I'm wondering if there is some necessity to wrapping errors. Should #11472 be solved another way with errors.Is or can this approach be accepted?

@kasey
Copy link
Contributor

kasey commented Sep 22, 2022

I seem to recall adding these wrappers to help with debugging as several methods use the same handleGetBlockError helper method, so the errors all look the same. Looking back at this I'm not sure if that was the right call, so I'm happy to accept this PR, as fixing this bug seems more important, and I'm not sure how much work would be required to add support for errors.Is to the grpc gateway code.

@prestonvanloon
Copy link
Member

Thanks @kasey !

prestonvanloon
prestonvanloon approved these changes Sep 22, 2022
View reviewed changes
Copy link
Member

@prestonvanloon prestonvanloon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@prylabs-bulldozer prylabs-bulldozer bot merged commit 2ea66a8 into prysmaticlabs:develop Sep 23, 2022
@prestonvanloon prestonvanloon mentioned this pull request Sep 23, 2022
Closed
@yierx yierx deleted the fix-http-status-code branch September 26, 2022 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prestonvanloon prestonvanloon prestonvanloon approved these changes

@kasey kasey kasey approved these changes

@potuz potuz Awaiting requested review from potuz potuz is a code owner automatically assigned from prysmaticlabs/core-team

@nisdas nisdas Awaiting requested review from nisdas nisdas is a code owner automatically assigned from prysmaticlabs/core-team

@james-prysm james-prysm Awaiting requested review from james-prysm james-prysm is a code owner automatically assigned from prysmaticlabs/core-team

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yierx @prestonvanloon @kasey @rkapka