Beacon api: produce block should skip mev-boost #11488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestonvanloon
requested changes
Sep 23, 2022
Comment on lines
47
to
62
| if !req.SkipMevBoost { | ||
| registered, err := vs.validatorRegistered(ctx, altairBlk.ProposerIndex) | ||
| if registered && err == nil { | ||
| builderReady, b, err := vs.GetAndBuildBlindBlock(ctx, altairBlk) | ||
| if err != nil { | ||
| // In the event of an error, the node should fall back to default execution engine for building block. | ||
| log.WithError(err).Error("Failed to build a block from external builder, falling " + | ||
| "back to local execution client") | ||
| builderGetPayloadMissCount.Inc() | ||
| } else if builderReady { | ||
| return b, nil | ||
| } | ||
| } else if err != nil { | ||
| log.WithFields(logrus.Fields{ | ||
| "slot": req.Slot, | ||
| "validatorIndex": altairBlk.ProposerIndex, | ||
| }).Errorf("Could not determine validator has registered. Default to local execution client: %v", err) | ||
| } | ||
| } else if err != nil { | ||
| log.WithFields(logrus.Fields{ | ||
| "slot": req.Slot, | ||
| "validatorIndex": altairBlk.ProposerIndex, | ||
| }).Errorf("Could not determine validator has registered. Default to local execution client: %v", err) |
There was a problem hiding this comment.
Please add tests for these changes
There was a problem hiding this comment.
req.SkipMevBoost is true is tested through TestProduceBlockV2SSZ and TestProduceBlockV2.
req.SkipMevBoost is false is tested through TestServer_GetBellatrixBeaconBlock_BuilderCase. Local test case.
There was a problem hiding this comment.
Also added another local test TestServer_GetBellatrixBeaconBlock_LocalProgressingWithBuilderSkipped
Comment on lines
340
to
341
| // By definition `/eth/v2/validator/blocks/{slot}/ssz`, does not produce block using mev-boost and relayer network: | ||
| // https://ethereum.github.io/beacon-APIs/?urls.primaryName=v2.3.0#/Validator/produceBlockV2 |
There was a problem hiding this comment.
Please add a suggestion to which API endpoint is supposed to be used for MEV boost / relay. I.e. blinded blocks endpoint.
The link you provided doesn't define anything about whether or not mev-boost should be used.
beacon-chain/rpc/prysm/v1alpha1/validator/proposer_bellatrix.go
Outdated
Show resolved
Hide resolved
Co-authored-by: Preston Van Loon <preston@prysmaticlabs.com>
prestonvanloon
approved these changes
Sep 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do? Why is it needed?
When calling beacon API
/eth/v2/validator/blocks/{slot}and/eth/v2/validator/blocks/{slot}/ssz, these end points should not call mev-boost/relayer to outsource block construction. This PR fixes it by adding fieldSkipMevBoosttoBlockRequestsuch that ifSkipMevBoostis true, the prysm API server will not attempt to reach mev-boost. This is the cleanest solution IMO, the other options are to refactor prysm API's get beacon block into two methods where one calls mev-boost and one doesn'tWhich issues(s) does this PR fix?
Fixes #11481
Other notes for review
Given that this is a protobuf change, we'll need to be careful there's no backward compatibility issue between beacon node and validator.