-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keymanager API: fix fee recipient API and add persistence #11540
Conversation
validator/client/runner.go
Outdated
log.Infof("Validator client started with provided proposer settings. The client will periodically signal updated settings such as fee recipient"+ | ||
" in the beacon node and custom builder ( if --%s)", flags.EnableBuilderFlag.Name) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After the update the log is a bit ungrammatical/incorrect:
The client will periodically signal updated settings such as fee recipient in the beacon node and custom builder
v.proposerSettings = settings | ||
v.validator.SetProposerSettings(settings) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why have proposer settings in two places when we can read them from v.validator
? This can cause bugs when we update in one place but not the other.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is what caused the original problem, unfortunately...
the runner.go has access to the validator directly but other parts such as the API only has access to the validator service and not the validator inside it... the node service at startup passes the data via config to the validator service into the validator as well ( the validator is only created with the values on validator service start). To try to remediate some of this I made the validator service's proposersettings private and calling the update this way will update both. open to other suggestions on this.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
This PR address 2 issues.
Which issues(s) does this PR fix?
Fixes #11322,#11539