Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vendor Leaky Bucket Implementation #11560

Merged
merged 22 commits into from
Oct 20, 2022
Merged

Vendor Leaky Bucket Implementation #11560

merged 22 commits into from
Oct 20, 2022

Conversation

nisdas
Copy link
Member

@nisdas nisdas commented Oct 19, 2022

What type of PR is this?

Feature Improvement

What does this PR do? Why is it needed?

We now vendor the leaky bucket implementation in prysm so that we can add more granular controls to it.

  • Add in period to leaky bucket to allow differing time periods to be used in a leaky bucket instance.
  • Fix References in prysm.
  • Add tests for new leaky bucket feature.

Which issues(s) does this PR fix?

N.A

Other notes for review

@nisdas nisdas requested a review from a team as a code owner October 19, 2022 12:36
nisdas and others added 2 commits October 20, 2022 21:56
prestonvanloon
prestonvanloon approved these changes Oct 20, 2022
View reviewed changes
Copy link
Member

@prestonvanloon prestonvanloon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@prestonvanloon prestonvanloon merged commit 661cbc4 into develop Oct 20, 2022
@delete-merged-branch delete-merged-branch bot deleted the vendorleakyBucket branch October 20, 2022 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prestonvanloon prestonvanloon prestonvanloon approved these changes

@kasey kasey Awaiting requested review from kasey kasey is a code owner automatically assigned from prysmaticlabs/core-team

@terencechain terencechain Awaiting requested review from terencechain terencechain is a code owner automatically assigned from prysmaticlabs/core-team

@rkapka rkapka Awaiting requested review from rkapka rkapka is a code owner automatically assigned from prysmaticlabs/core-team

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nisdas @prestonvanloon @terencechain