Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve remaining native state tasks #11561

Merged
merged 6 commits into from
Oct 19, 2022
Merged

Resolve remaining native state tasks #11561

merged 6 commits into from
Oct 19, 2022

Conversation

rkapka
Copy link
Contributor

@rkapka rkapka commented Oct 19, 2022

What type of PR is this?

Cleanup

What does this PR do? Why is it needed?

Resolves tasks mentioned in #10100.

Which issues(s) does this PR fix?

Fixes #10100

@rkapka rkapka requested a review from a team as a code owner October 19, 2022 13:51
@rkapka
Copy link
Contributor Author

rkapka commented Oct 19, 2022

take a closer look at copies such as #10086 (comment); can they be avoided?

Can we optimize this somehow?

rauljordan
rauljordan approved these changes Oct 19, 2022
View reviewed changes
Copy link
Contributor

@rauljordan rauljordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scanned through this and pretty straightforward

@rauljordan rauljordan merged commit b7a878d into develop Oct 19, 2022
@delete-merged-branch delete-merged-branch bot deleted the beacon-state-epilogue branch October 19, 2022 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rauljordan rauljordan rauljordan approved these changes

@kasey kasey Awaiting requested review from kasey kasey is a code owner automatically assigned from prysmaticlabs/core-team

@terencechain terencechain Awaiting requested review from terencechain terencechain is a code owner automatically assigned from prysmaticlabs/core-team

@nisdas nisdas Awaiting requested review from nisdas nisdas is a code owner automatically assigned from prysmaticlabs/core-team

Assignees
No one assigned
Labels
Cleanup Code health!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Tracking] Native Beacon State - things not to forget
2 participants
@rkapka @rauljordan