Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EIP-4881: Add merkle tree interface #11597

Merged
merged 4 commits into from
Nov 1, 2022
Merged

EIP-4881: Add merkle tree interface #11597

merged 4 commits into from
Nov 1, 2022

Conversation

saolyn
Copy link
Contributor

@saolyn saolyn commented Oct 31, 2022 •
edited by rkapka
Loading

What type of PR is this?

Feature

What does this PR do? Why is it needed?
Part 1 of the implementation of an optimized deposit tree as specified in eip-4881.
This PR contains the interface for a Merkle tree according to the spec.

Which issues(s) does this PR fix?

Part of #11256

Other notes for review

@saolyn saolyn requested a review from prestonvanloon October 31, 2022 18:20
@saolyn saolyn requested a review from a team as a code owner October 31, 2022 18:20
@saolyn saolyn requested review from potuz and james-prysm October 31, 2022 18:21
@saolyn saolyn changed the title Add merkle tree interface EIP-4881: Add merkle tree interface Oct 31, 2022
terencechain
terencechain approved these changes Oct 31, 2022
View reviewed changes
Copy link
Member

@terencechain terencechain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@rkapka
Copy link
Contributor

rkapka commented Nov 1, 2022

@saolyn I changed Fixes #... to Part of #... because having the former would close the issue after merging. See https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword

nisdas
nisdas approved these changes Nov 1, 2022
View reviewed changes
Copy link
Member

@nisdas nisdas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prylabs-bulldozer prylabs-bulldozer bot merged commit 001ae30 into develop Nov 1, 2022
@delete-merged-branch delete-merged-branch bot deleted the eip4881-merkle-tree-interface branch November 1, 2022 23:31
@saolyn saolyn mentioned this pull request Nov 2, 2022
Closed
@potuz potuz mentioned this pull request Apr 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nisdas nisdas nisdas approved these changes

@terencechain terencechain terencechain approved these changes

@prestonvanloon prestonvanloon Awaiting requested review from prestonvanloon

@potuz potuz Awaiting requested review from potuz potuz is a code owner automatically assigned from prysmaticlabs/core-team

@james-prysm james-prysm Awaiting requested review from james-prysm james-prysm is a code owner automatically assigned from prysmaticlabs/core-team

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@saolyn @rkapka @terencechain @nisdas