Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy Bytes Safely When Accessing Withdrawals #11638

Merged
merged 2 commits into from
Nov 8, 2022
Merged

Conversation

nisdas
Copy link
Member

@nisdas nisdas commented Nov 8, 2022

What type of PR is this?

Clean Up

What does this PR do? Why is it needed?

This follows on from #11618 where we copy bytes from the withdrawal field, rather than directly referencing those bytes
when creating the withdrawal object.

Which issues(s) does this PR fix?

N.A

Other notes for review

@nisdas nisdas requested a review from a team as a code owner November 8, 2022 10:22
@prylabs-bulldozer prylabs-bulldozer bot merged commit 02566de into develop Nov 8, 2022
@delete-merged-branch delete-merged-branch bot deleted the safeCopyBytes branch November 8, 2022 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants