Add REST implementation for Validator's WaitForChainStart #11654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dB2510
reviewed
Nov 15, 2022
dB2510
reviewed
Nov 15, 2022
rkapka
reviewed
Nov 15, 2022
…ithub.com:PatriceVignola/prysm into user/pavignol/add-wait-for-chain-start-beacon-api
PatriceVignola
requested review from
rkapka
and removed request for
saolyn,
potuz and
terencechain
rkapka
reviewed
Nov 15, 2022
rkapka
previously approved these changes
Nov 21, 2022
rkapka
requested changes
Nov 21, 2022
There was a problem hiding this comment.
This is great! But the new waitForChainStart function doesn't have any tests. I think you should be able to write some with the help of https://pkg.go.dev/net/http/httptest for mocking.
prestonvanloon
requested changes
Nov 21, 2022
…ithub.com:PatriceVignola/prysm into user/pavignol/add-wait-for-chain-start-beacon-api
PatriceVignola
requested review from
prestonvanloon and
rkapka
and removed request for
prestonvanloon and
rkapka
PatriceVignola
requested review from
prestonvanloon
and removed request for
rkapka
prestonvanloon
requested changes
Nov 21, 2022
prestonvanloon
approved these changes
Nov 21, 2022
| "github.com/prysmaticlabs/prysm/v3/testing/assert" | ||
| ) | ||
|
|
||
| func TestBeaconApiHelpers(t *testing.T) { |
There was a problem hiding this comment.
Nice! In my opinion, this is so much cleaner.
rkapka
approved these changes
Nov 22, 2022
PatriceVignola
deleted the
user/pavignol/add-wait-for-chain-start-beacon-api
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
This adds an implementation for the
WaitForChainStartvalidator client method by caling the Beacon Node REST API instead of the gRPC one.