Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix withdrawalRoot hasher #11655

Merged
merged 2 commits into from
Nov 12, 2022
Merged

Fix withdrawalRoot hasher #11655

merged 2 commits into from
Nov 12, 2022

Conversation

potuz
Copy link
Contributor

@potuz potuz commented Nov 12, 2022

This PR fixes a bug in the withdrawalRoot hashing, adds a test for it and also adds a test for the exported function WithdrawalSliceRoot function.

@potuz potuz added Bug Something isn't working Ready For Review labels Nov 12, 2022
@potuz potuz requested a review from a team as a code owner November 12, 2022 11:44
@terencechain terencechain merged commit 68c3e93 into develop Nov 12, 2022
@delete-merged-branch delete-merged-branch bot deleted the withdrawal_hashing branch November 12, 2022 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terencechain terencechain terencechain approved these changes

@rkapka rkapka Awaiting requested review from rkapka rkapka is a code owner automatically assigned from prysmaticlabs/core-team

@nisdas nisdas Awaiting requested review from nisdas nisdas is a code owner automatically assigned from prysmaticlabs/core-team

@james-prysm james-prysm Awaiting requested review from james-prysm james-prysm is a code owner automatically assigned from prysmaticlabs/core-team

Assignees
No one assigned
Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@potuz @terencechain