Upgrade getBlindedBlock API endpoint to Capella
#11687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit e5c269ddf7b0c9e04f72ed28982a82de56fcac55)
(cherry picked from commit 1719ce5967b0f74786c596cc921f7256e6b224f3)
potuz
reviewed
Nov 24, 2022
| assert.Equal(t, "root", beaconBlock.ParentRoot) | ||
| assert.Equal(t, "root", beaconBlock.StateRoot) | ||
| assert.NotNil(t, beaconBlock.Body) | ||
| assert.Equal(t, true, resp.ExecutionOptimistic) |
There was a problem hiding this comment.
Do we want to check the execution payload header here?
| @@ -813,6 +813,77 @@ func (bs *Server) GetBlindedBlock(ctx context.Context, req *ethpbv1.BlockRequest | |||
| return nil, status.Errorf(codes.Internal, "Could not get signed beacon block: %v", err) | |||
| } | |||
|
|
|||
| capellaBlk, err := blk.PbCapellaBlock() | |||
There was a problem hiding this comment.
This function is unreadably long, can we talk about ways of avoiding all this code duplication? or even if we are going to duplicate it, perhaps having each case as a helper?
There was a problem hiding this comment.
I refactored the code and put it into its own file. Deduplicating is hard because there are lot of differences in terms of block types and function calls.
rkapka
force-pushed
the
capella-api-getblindedblock
branch
from
7608e78 to
617b1c4
Compare
rkapka
force-pushed
the
capella-api-getblindedblock
branch
from
617b1c4 to
134b218
Compare
potuz
reviewed
Nov 28, 2022
saolyn
reviewed
Nov 28, 2022
Co-authored-by: Potuz <potuz@prysmaticlabs.com>
potuz
previously approved these changes
Nov 28, 2022
potuz
approved these changes
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
Upgrades https://ethereum.github.io/beacon-APIs/?urls.primaryName=dev#/Beacon/getBlindedBlock to handle Capella blocks.