Add Gossip Handler For BLS To Execution Changes #11690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potuz
reviewed
Nov 26, 2022
| @@ -473,6 +475,28 @@ func defaultVoluntaryExitTopicParams() *pubsub.TopicScoreParams { | |||
| } | |||
| } | |||
|
|
|||
| func defaultBlsToExecutionChangeTopicParams() *pubsub.TopicScoreParams { | |||
| return &pubsub.TopicScoreParams{ | |||
| TopicWeight: voluntaryExitWeight, | |||
There was a problem hiding this comment.
If this weight is really going to be a constant then we need to return the same as above and avoid code duplication.
There was a problem hiding this comment.
good catch, this is the incorrect weight. I will have to set a new one for our scoring params
potuz
approved these changes
Nov 26, 2022
| // Validate the signature of the message using our batch gossip verifier. | ||
| sigBatch, err := blocks.BLSChangesSignatureBatch(ctx, st, []*ethpb.SignedBLSToExecutionChange{blsChange}) | ||
| if err != nil { | ||
| return pubsub.ValidationReject, err |
There was a problem hiding this comment.
I can see a counterargument on why this should be ValidationIgnore. I think it's close between the two
terencechain
approved these changes
Nov 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature For Withdrawals
What does this PR do? Why is it needed?
Which issues(s) does this PR fix?
Part of #11077
Other notes for review