Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update block Beacon APIs to Capella #11706

Merged
merged 23 commits into from
Dec 15, 2022
Merged

Conversation

rkapka
Copy link
Contributor

@rkapka rkapka commented Nov 29, 2022

What type of PR is this?

Feature

What does this PR do? Why is it needed?

Updates the following endpoints to allow Capella blocks:

Big thanks to @potuz for implementing endpoints on capella, I mostly refactored and added tests.

(cherry picked from commit 97483c339f99b0d96bd81846a979383ffd2b0cda)

# Conflicts:
#	beacon-chain/rpc/eth/beacon/blocks.go
(cherry picked from commit 9e4e82d)

# Conflicts:
#	beacon-chain/rpc/eth/beacon/blocks.go
(cherry picked from commit 5d6fd0bbe663e5dd16df5b2e773f68982bbcd24e)
(cherry picked from commit 82f6ddb)
(cherry picked from commit 52bc2c8d617ac3e1254c493fa053cdce4a1ebd63)
(cherry picked from commit d7d70bc)
(cherry picked from commit c1d4eaa)

# Conflicts:
#	beacon-chain/rpc/eth/beacon/blocks.go
(cherry picked from commit fbc4e73)

# Conflicts:
#	beacon-chain/rpc/eth/beacon/blocks.go
(cherry picked from commit 31d4a4c)
(cherry picked from commit 0a9e165)

# Conflicts:
#	beacon-chain/rpc/eth/beacon/blocks.go
@rkapka rkapka added API Api related tasks Withdrawals labels Nov 29, 2022
@rkapka rkapka requested a review from a team as a code owner November 29, 2022 19:31
@rkapka rkapka force-pushed the capella-block-apis branch from 4f1e875 to 1929424 Compare November 29, 2022 20:15
@rkapka rkapka marked this pull request as draft November 29, 2022 20:43
proto/eth/v2/BUILD.bazel Outdated Show resolved Hide resolved
proto/migration/v1alpha1_to_v2.go Outdated Show resolved Hide resolved
# Conflicts:
#	proto/eth/v2/beacon_block.pb.go
# Conflicts:
#	beacon-chain/rpc/eth/beacon/blocks.go
@rkapka rkapka marked this pull request as ready for review December 14, 2022 14:07
@rkapka rkapka force-pushed the capella-block-apis branch from 4605a6d to 93cca9d Compare December 14, 2022 14:35
@terencechain
Copy link
Member

Lgtm! do we want a second eye for this? @potuz @nisdas or @james-prysm ?

Copy link
Contributor

@saolyn saolyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm too

Copy link
Contributor

@james-prysm james-prysm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@prylabs-bulldozer prylabs-bulldozer bot merged commit cb02a68 into develop Dec 15, 2022
@delete-merged-branch delete-merged-branch bot deleted the capella-block-apis branch December 15, 2022 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Api related tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants