-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update block Beacon APIs to Capella #11706
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 97483c339f99b0d96bd81846a979383ffd2b0cda) # Conflicts: # beacon-chain/rpc/eth/beacon/blocks.go (cherry picked from commit 9e4e82d) # Conflicts: # beacon-chain/rpc/eth/beacon/blocks.go
(cherry picked from commit 5d6fd0bbe663e5dd16df5b2e773f68982bbcd24e) (cherry picked from commit 82f6ddb)
(cherry picked from commit 52bc2c8d617ac3e1254c493fa053cdce4a1ebd63) (cherry picked from commit d7d70bc)
(cherry picked from commit c1d4eaa) # Conflicts: # beacon-chain/rpc/eth/beacon/blocks.go
(cherry picked from commit fbc4e73) # Conflicts: # beacon-chain/rpc/eth/beacon/blocks.go
(cherry picked from commit 31d4a4c)
(cherry picked from commit 0a9e165) # Conflicts: # beacon-chain/rpc/eth/beacon/blocks.go
rkapka
force-pushed
the
capella-block-apis
branch
from
November 29, 2022 20:15
4f1e875
to
1929424
Compare
# Conflicts: # proto/eth/v2/beacon_block.pb.go
# Conflicts: # beacon-chain/rpc/eth/beacon/blocks.go
rkapka
force-pushed
the
capella-block-apis
branch
from
December 14, 2022 14:35
4605a6d
to
93cca9d
Compare
Lgtm! do we want a second eye for this? @potuz @nisdas or @james-prysm ? |
saolyn
reviewed
Dec 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm too
saolyn
approved these changes
Dec 15, 2022
james-prysm
approved these changes
Dec 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
Updates the following endpoints to allow Capella blocks:
Big thanks to @potuz for implementing endpoints on
capella
, I mostly refactored and added tests.