Correct duties calculation for old slots #11723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-prysm
previously approved these changes
Dec 6, 2022
|
This needs more careful thought. Marking as draft for now. |
rkapka
commented
Dec 7, 2022
| @@ -268,21 +267,38 @@ func TestGetProposerDuties(t *testing.T) { | |||
| } | |||
| vid, _, has := vs.ProposerSlotIndexCache.GetProposerPayloadIDs(11, [32]byte{}) | |||
| require.Equal(t, true, has) | |||
| require.Equal(t, types.ValidatorIndex(12289), vid) | |||
| require.Equal(t, types.ValidatorIndex(9982), vid) | |||
There was a problem hiding this comment.
This changed because state's slot changed from 5 to params.BeaconConfig().SlotsPerEpoch. The implementation will always fetch a slot at an epoch boundary, which is why I modified the slot in the test.
roberto-bayardo
pushed a commit
to roberto-bayardo/prysm
that referenced
this pull request
Dec 17, 2022
* initial code * update proposalDependentRoot * convert method to function * decouple tests Co-authored-by: terencechain <terence@prysmaticlabs.com>
PatriceVignola
added a commit
to PatriceVignola/prysm
that referenced
this pull request
Dec 21, 2022
This reverts commit 9efc89f.
PatriceVignola
added a commit
to PatriceVignola/prysm
that referenced
this pull request
Dec 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
All our duties' calculation are based on the head state, which means that fetching duties older than
SLOTS_PER_HISTORICAL_ROOTproduces wrong results. This is because the state does not contain block roots older thanSLOTS_PER_HISTORICAL_ROOTand these roots are used when:This PR also reverts some changes from #11015. Because we use
dependentRootSlot = epochStartSlot.Sub(1)as the slot, the initial dependent root calculation originally worked fine for the next epoch. The update from 11015 stops working with the current changes becausedependentRootSlot >= s.Slot()no longer checks for future slots (at least not always) when we don't use the head state.Which issues(s) does this PR fix?
Fixes #11628