Adding exit codes to cli commands #11735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-prysm
added
UX
|
Wouldn't it make sense to return the |
rkapka
approved these changes
Dec 13, 2022
roberto-bayardo
pushed a commit
to roberto-bayardo/prysm
that referenced
this pull request
Dec 17, 2022
* adding exit codes to cmd * adding in fatal logs to other cli actions Co-authored-by: Radosław Kapka <rkapka@wp.pl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
the cli library we use https://cli.urfave.org/v2/examples/exit-codes/ by default sets the exit code to 0 even if errors occurred. in order for our cli commands to return a '1' for exit code on failure we need to explicitly wrap the action for the cli
Which issues(s) does this PR fix?
Fixes #11715