Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Back Cross Client Option #11738

Merged
merged 3 commits into from
Dec 8, 2022
Merged

Add Back Cross Client Option #11738

merged 3 commits into from
Dec 8, 2022

Conversation

nisdas
Copy link
Member

@nisdas nisdas commented Dec 8, 2022

What type of PR is this?

E2E Fix

What does this PR do? Why is it needed?

This re-enables our cross client e2e option along with allowing us to run the multiclient api evaluator. Previous test runs were failing because the evaluator was being applied to tests with no LH nodes. This makes sure the evaluator is only applied if LH nodes are running.

Which issues(s) does this PR fix?

N.A

Other notes for review

@nisdas nisdas added Ready For Review E2E Tests End-To-End testing labels Dec 8, 2022
@nisdas nisdas requested a review from a team as a code owner December 8, 2022 03:21
Copy link
Contributor

@james-prysm james-prysm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for the input

@james-prysm james-prysm merged commit 642c399 into develop Dec 8, 2022
@delete-merged-branch delete-merged-branch bot deleted the crossClientOption branch December 8, 2022 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E2E Tests End-To-End testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants