beacondb: Remove cache look up and lock request from boltdb transaction for state summaries #11745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestonvanloon
commented
Dec 8, 2022
kasey
reviewed
Dec 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other
What does this PR do? Why is it needed?
As title describes, we should never attempt to secure a lock during a boltdb transaction as the transaction could be blocking other, unrelated, boltdb transactions.
Which issues(s) does this PR fix?
Other notes for review
This PR acknowledges a prior issue that was solved in #9428 where opening a view transaction within an update transaction was problematic. We are revisiting that same problem where with a different solution that does not attempt to secure any cache lock within a bolt transaction.