Add capella cases for RPC calls #11759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nisdas
reviewed
Dec 13, 2022
| @@ -528,7 +528,7 @@ func (bs *Server) GetValidatorParticipation( | |||
| if err != nil { | |||
| return nil, status.Errorf(codes.Internal, "Could not pre compute attestations: %v", err) | |||
| } | |||
| case version.Altair, version.Bellatrix: | |||
| case version.Altair, version.Bellatrix, version.Capella: | |||
There was a problem hiding this comment.
Do you think instead of switch we can just do
if stateversion >= version.Altair
That way we dont have to do this again in the next fork
nisdas
reviewed
Dec 13, 2022
| @@ -693,7 +693,7 @@ func (bs *Server) GetValidatorPerformance( | |||
| return nil, err | |||
| } | |||
| validatorSummary = vp | |||
| case version.Altair, version.Bellatrix: | |||
| case version.Altair, version.Bellatrix, version.Capella: | |||
nisdas
reviewed
Dec 13, 2022
| @@ -865,7 +865,7 @@ func (bs *Server) GetIndividualVotes( | |||
| if err != nil { | |||
| return nil, status.Errorf(codes.Internal, "Could not pre compute attestations: %v", err) | |||
| } | |||
| case version.Altair, version.Bellatrix: | |||
| case version.Altair, version.Bellatrix, version.Capella: | |||
nisdas
approved these changes
Dec 13, 2022
rkapka
approved these changes
Dec 13, 2022
roberto-bayardo
pushed a commit
to roberto-bayardo/prysm
that referenced
this pull request
Dec 17, 2022
* Add capella cases for rpc calls * Use if else Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing Capella cases for these RPC calls + tests: