Add finalized metadata field to API responses
#11783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkapka
commented
Dec 15, 2022
| @@ -173,6 +174,7 @@ func (bs *Server) ListBlockHeaders(ctx context.Context, req *ethpbv1.BlockHeader | |||
| } | |||
|
|
|||
| isOptimistic := false | |||
| isFinalized := true | |||
There was a problem hiding this comment.
We assume finalized and as long as we "are finalized", we update the value inside the loop.
rkapka
commented
Dec 15, 2022
Comment on lines
+421
to
-458
| b1 := util.NewBeaconBlock() | ||
| b1.Block.Slot = 30 | ||
| b1.Block.ParentRoot = bytesutil.PadTo([]byte{1}, 32) | ||
| util.SaveBlock(t, ctx, beaconDB, b1) | ||
| b2 := util.NewBeaconBlock() | ||
| b2.Block.Slot = 30 | ||
| b2.Block.ParentRoot = bytesutil.PadTo([]byte{1}, 32) | ||
| b2.Block.ParentRoot = bytesutil.PadTo([]byte{4}, 32) | ||
| util.SaveBlock(t, ctx, beaconDB, b2) | ||
| b3 := util.NewBeaconBlock() | ||
| b3.Block.Slot = 30 | ||
| b3.Block.ParentRoot = bytesutil.PadTo([]byte{4}, 32) | ||
| b3.Block.Slot = 31 | ||
| b3.Block.ParentRoot = bytesutil.PadTo([]byte{1}, 32) | ||
| util.SaveBlock(t, ctx, beaconDB, b3) | ||
| b4 := util.NewBeaconBlock() | ||
| b4.Block.Slot = 31 | ||
| b4.Block.Slot = 28 | ||
| b4.Block.ParentRoot = bytesutil.PadTo([]byte{1}, 32) | ||
| util.SaveBlock(t, ctx, beaconDB, b4) | ||
| b5 := util.NewBeaconBlock() | ||
| b5.Block.Slot = 28 | ||
| b5.Block.ParentRoot = bytesutil.PadTo([]byte{1}, 32) | ||
| util.SaveBlock(t, ctx, beaconDB, b5) |
There was a problem hiding this comment.
This diff is misleading, I simply changed names of b2/b3/b4/b5 to b1/b2/b3/b4.
rkapka
added
Ready For Review
rauljordan
previously approved these changes
Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
Implements ethereum/beacon-APIs#254 for the following endpoints:
It also simplifies some tests as they had unnecessary setup.
Which issues(s) does this PR fix?
Part of #11747