Add REST implementation for MultipleValidatorStatus
#11786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkapka
requested changes
Dec 19, 2022
rkapka
reviewed
Dec 19, 2022
|
|
||
| var lastActivatedValidatorIndex uint64 = 0 | ||
| // Set PositionInActivationQueue |
There was a problem hiding this comment.
Let's extract this to a private function setPositionInActivationQueue
nalepae
requested review from
rkapka
and removed request for
prestonvanloon,
nisdas and
james-prysm
rkapka
approved these changes
Dec 27, 2022
|
It seems some e2e tests fail because of Exemple: https://buildkite.com/prysmatic-labs/prysm/builds/69708#018577a1-b5ea-40ba-8922-2a0854c91921 - line 218 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
Related gitHub issue:
#11580
What does this PR do? Why is it needed?
This adds an implementation for the
MultipleValidatorStatusvalidator client method by calling the Beacon Node REST API instead of the gRPC one.Notes for reviewers:
I tried to mimic https://github.com/prysmaticlabs/prysm/blob/develop/beacon-chain/rpc/prysm/v1alpha1/validator/status.go#L55-L98.
A list of validators keys and validator indexes are given in inputs.
unknownand the corresponding validator index is set at the highest possibleuint64value.Compared to gRPC version, I did not keep the same order in the outputs.
I checked in the codebase where
MultipleValidatorStatusis used, and did not noticed any need for a specific output order.