Add back BLS changes from orphaned blocks #11822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
reviewed
Jan 1, 2023
| // It also filters out the attestations that is one epoch older as a defense so invalid attestations don't flow into the attestation pool. | ||
| func (s *Service) saveOrphanedAtts(ctx context.Context, orphanedRoot [32]byte, newHeadRoot [32]byte) error { | ||
| func (s *Service) saveOrphanedOperations(ctx context.Context, orphanedRoot [32]byte, newHeadRoot [32]byte) error { |
There was a problem hiding this comment.
Tbf this doesn't save all the operations, we should move slashing and exit to here in subsequent PR
There was a problem hiding this comment.
Yep, was working on it when vacations started :)
terencechain
approved these changes
Jan 1, 2023
nisdas
reviewed
Jan 3, 2023
| return errors.Wrap(err, "could not get BLSToExecutionChanges") | ||
| } | ||
| for _, c := range changes { | ||
| s.cfg.BLSToExecPool.InsertBLSToExecChange(c) |
There was a problem hiding this comment.
What happens if the current branch already has these bls changes included ? Do we rely on our block packing to filter them out ?
There was a problem hiding this comment.
Insertion is a noop in this case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of a reorg, add back the BLS changes in the orphaned blocks.