Fix Waiting For Bandwidth Issue While Syncing #11853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nisdas
added
Networking
rauljordan
reviewed
Jan 9, 2023
Comment on lines
378
to
382
| tillEmpty := f.rateLimiter.TillEmpty(pid.String()) | ||
| blocksNeeded := int64(count - uint64(rem)) | ||
| currentNumBlks := f.rateLimiter.Capacity() - rem | ||
| expectedTime := int64(tillEmpty) * blocksNeeded / currentNumBlks | ||
| timer := time.NewTimer(time.Duration(expectedTime)) |
There was a problem hiding this comment.
Would be best if we abstract this into a small helper where the right math can be tested
|
tests fail @nisdas |
terencechain
approved these changes
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Syncing Improvement
What does this PR do? Why is it needed?
In smaller devnets, it came up that prysm was waiting an excessive period of time for peers to replenish their limits
for our leaky bucket. We modify our bandwidth waiting method, to more accurately gauge when it is the right time to correctly
request blocks from those particular peers again. This also adds a unit test for this particular case
Which issues(s) does this PR fix?
N.A
Other notes for review