Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix TestEndToEnd_MinimalConfig_ValidatorRESTApi test #11856

Merged
merged 2 commits into from
Jan 9, 2023

Conversation

dB2510
Copy link
Contributor

@dB2510 dB2510 commented Jan 9, 2023

What type of PR is this?

Bug fix

What does this PR do? Why is it needed?

This PR fixes a bug in SubmitSyncMessage REST implementation which caused TestEndToEnd_MinimalConfig_ValidatorRESTApi/validator_sync_participation_6 to fail.

Other notes for review
SubmitSyncMessage endpoint takes an array of sync committee messages as request body (refer: https://ethereum.github.io/beacon-APIs/#/ValidatorRequiredApi/submitPoolSyncCommitteeSignatures).

@dB2510 dB2510 requested a review from a team as a code owner January 9, 2023 19:12
@dB2510 dB2510 requested review from kasey, rauljordan and potuz January 9, 2023 19:12
@rkapka rkapka merged commit a7a6463 into prysmaticlabs:develop Jan 9, 2023
@dB2510 dB2510 deleted the fix-end-to-end-minimal-test branch February 9, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants