Capella State Detection #11862
Merged
Capella State Detection #11862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
previously approved these changes
Jan 11, 2023
terencechain
previously approved these changes
Jan 12, 2023
Co-authored-by: terencechain <terence@prysmaticlabs.com>
terencechain
approved these changes
Jan 13, 2023
kasey
added a commit
that referenced
this pull request
Jan 13, 2023
* capella state version detection bug fix * add capella to yaml "template" * changes for capella state detection * lint * don't set capella fork version == altair!!! * less brittle test for fork schedule rpc * fix assertions that use wrong field name * don't test capella/sharding fv against upstream * hat tip Terence for sanity check * Update config/params/loader_test.go Co-authored-by: terencechain <terence@prysmaticlabs.com> Co-authored-by: Kasey Kirkham <kasey@users.noreply.github.com> Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com> Co-authored-by: terencechain <terence@prysmaticlabs.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
Adds support for starting from capella genesis. Unfortunately we have to add some new code for each fork, because deriving the beacon block from the state is version dependent, and there is a switch in the version detection code that needs to be updated.
Other notes for review
This PR also cherry picks some changes that were committed directly to the capella branch, and replicates some other changes that are in that branch but not in develop, so there will be some conflicts when we pick the changes over to capella. I can manage picking those changes over.