Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use LIFO instead of FIFO when packing BLS changes #11896

Merged
merged 1 commit into from
Jan 20, 2023
Merged

Use LIFO instead of FIFO when packing BLS changes #11896

merged 1 commit into from
Jan 20, 2023

Conversation

potuz
Copy link
Contributor

@potuz potuz commented Jan 20, 2023

See this discussion for context:

https://discord.com/channels/595666850260713488/892088344438255616/1065818533403037806

TL;DR: this encourages users with uncompromized keys to not flood at the fork boundary

@potuz potuz requested a review from a team as a code owner January 20, 2023 03:37
terencechain
terencechain approved these changes Jan 20, 2023
View reviewed changes
Copy link
Member

@terencechain terencechain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic-wise looks good to me. I'd love for another approval before merge.

@michaelsproul michaelsproul mentioned this pull request Jan 20, 2023
Merged
6 tasks
@prylabs-bulldozer prylabs-bulldozer bot merged commit 2fee906 into develop Jan 20, 2023
@delete-merged-branch delete-merged-branch bot deleted the bls-lifo branch January 20, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkapka rkapka rkapka approved these changes

@terencechain terencechain terencechain approved these changes

@kasey kasey Awaiting requested review from kasey kasey is a code owner automatically assigned from prysmaticlabs/core-team

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@potuz @terencechain @rkapka