Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update builder code to Capella #11904

Merged
merged 20 commits into from
Jan 26, 2023
Merged

Update builder code to Capella #11904

merged 20 commits into from
Jan 26, 2023

Conversation

rkapka
Copy link
Contributor

@rkapka rkapka commented Jan 23, 2023

What type of PR is this?

Feature

What does this PR do? Why is it needed?

Implements ethereum/builder-specs#60

Which issues(s) does this PR fix?

Part of #11077

@rkapka rkapka marked this pull request as ready for review January 24, 2023 16:42
@rkapka rkapka requested a review from a team as a code owner January 24, 2023 16:42

// SubmitBlindedBlockCapella calls the builder API endpoint that binds the validator to the builder and submits the block.
// The response is the full ExecutionPayloadCapella used to create the blinded block.
func (c *Client) SubmitBlindedBlockCapella(ctx context.Context, sb *ethpb.SignedBlindedBeaconBlockCapella) (*v1.ExecutionPayloadCapella, error) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be v2 path

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talked to Alex, the existing one supports Capella

// GetHeader is used by a proposing validator to request an ExecutionPayloadHeader from the Builder node.
func (c *Client) GetHeader(ctx context.Context, slot types.Slot, parentHash [32]byte, pubkey [48]byte) (*ethpb.SignedBuilderBid, error) {
// GetHeader is used by a proposing validator to request an execution payload header from the Builder node.
func (c *Client) GetHeader(ctx context.Context, slot types.Slot, parentHash [32]byte, pubkey [48]byte) (SignedBid, error) {
path, err := execHeaderPath(slot, parentHash, pubkey)
Copy link
Member

@terencechain terencechain Jan 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be v2 path as well

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talked to Alex, the existing one supports Capella

@rkapka rkapka merged commit a296a0c into develop Jan 26, 2023
@rkapka rkapka deleted the capella-builder branch January 26, 2023 13:07
@rkapka rkapka mentioned this pull request Jan 26, 2023
28 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants