Cache Fork Digest Computation #11931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
approved these changes
Jan 29, 2023
There was a problem hiding this comment.
This looks good to me. There are two feedbacks to consider that I don't feel strongly about. Anyone feel free to block this if you think they are necessary:
- Refactor
string(version)+string(root)into its own helper function - Add a lock around
computeForkDataRootto avoid race
Keep in mind that there's no pruning for the map after a while and that's probably ok given this is a rare event
|
Ops. I didn't see |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Optimization
What does this PR do? Why is it needed?
Computing the fork digest is a very hot path in gossip, we have to compute the digest for each message we
receive in gossip. This PR caches the computation, so that we can easily received the result through a map. Also
a relevant unit test is added here.
Which issues(s) does this PR fix?
N.A
Other notes for review