Utilize Read Only Head State #11932
Merged
Utilize Read Only Head State #11932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potuz
requested changes
Jan 30, 2023
| // HeadStateReadOnly returns the read only head state of the chain. | ||
| // If the head is nil from service struct, | ||
| // it will attempt to get the head state from DB. | ||
| func (s *Service) HeadStateReadOnly(ctx context.Context) (state.ReadOnlyBeaconState, error) { |
There was a problem hiding this comment.
Can we add a trivial unit test to make sure that all paths are covered here and protect from our future selfs?
terencechain
approved these changes
Jan 31, 2023
potuz
approved these changes
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature Addition
What does this PR do? Why is it needed?
This PR introduces a method to access a read only version of the head state without performing any copies. This is very
useful in gossip when trying to fetch the head state to validate objects from gossip. This method has been introduced as
a way to more efficiently verify BLS change messages.
Which issues(s) does this PR fix?
N.A
Other notes for review