add REST implementation for GetSyncSubcommitteeIndex #11971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nalepae
reviewed
Feb 7, 2023
Comment on lines
116
to
124
| var indices []primitives.CommitteeIndex | ||
| for _, idx := range syncDuty.ValidatorSyncCommitteeIndices { | ||
| syncCommIdx, err := strconv.ParseUint(idx, 10, 64) | ||
| if err != nil { | ||
| return nil, errors.Wrap(err, "failed to parse validator sync committee index") | ||
| } | ||
|
|
||
| indices = append(indices, primitives.CommitteeIndex(syncCommIdx)) | ||
| } |
There was a problem hiding this comment.
Suggested change
| var indices []primitives.CommitteeIndex | |
| for _, idx := range syncDuty.ValidatorSyncCommitteeIndices { | |
| syncCommIdx, err := strconv.ParseUint(idx, 10, 64) | |
| if err != nil { | |
| return nil, errors.Wrap(err, "failed to parse validator sync committee index") | |
| } | |
| indices = append(indices, primitives.CommitteeIndex(syncCommIdx)) | |
| } | |
| indices := make([]primitives.CommitteeIndex, len(syncDuty.ValidatorSyncCommitteeIndices)) | |
| for i, idx := range syncDuty.ValidatorSyncCommitteeIndices { | |
| syncCommIdx, err := strconv.ParseUint(idx, 10, 64) | |
| if err != nil { | |
| return nil, errors.Wrap(err, "failed to parse validator sync committee index") | |
| } | |
| indices[i] = primitives.CommitteeIndex(syncCommIdx) | |
| } |
There was a problem hiding this comment.
Hi @nalepae !
Slice initialisation with make is recommended when the length of slice is constant or already known. In our case it length of indices depends on length syncDuty.ValidatorSyncCommitteeIndices slice. If syncDuty.ValidatorSyncCommitteeIndices slice is empty/nil then it doesn't make sense to pre-allocate indices slice. This makes zero value of slice useful, also recommended by Rob Pike: https://www.youtube.com/watch?v=PAAkCSZUG1c&t=385s
rkapka
reviewed
Feb 8, 2023
|
|
||
| // TODO: Implement me | ||
| panic("beaconApiValidatorClient.GetSyncCommitteeContribution is not implemented. To use a fallback client, create this validator with NewBeaconApiValidatorClientWithFallback instead.") | ||
| return c.getSyncCommitteeContribution(ctx, in) |
Co-authored-by: Radosław Kapka <radek@prysmaticlabs.com>
dB2510
requested review from
rkapka
and removed request for
prestonvanloon,
saolyn and
nisdas
rkapka
approved these changes
Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
Related issue
#11580
What does this PR do? Why is it needed?
It adds REST API implementation for
GetSyncSubcommitteeIndex.