Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for ropsten testnet #12004

Conversation

peterbitfly
Copy link
Contributor

What type of PR is this?
Bug fix

What does this PR do? Why is it needed?
Currently prysm does not work together with geth v1.11.0 when used as a module. This is because prysm still maintains a config for the now obsolete ropsten testnet and imports some configuration details from geth. With geth v1.11.0 this definitions were removed and now prysm breaks the following error as soon as it is imported together with geth:

# github.com/prysmaticlabs/prysm/v3/config/params
../../pkg/mod/github.com/prysmaticlabs/prysm/v3@v3.1.1/config/params/testnet_ropsten_config.go:29:34: undefined: params.RopstenChainConfig
../../pkg/mod/github.com/prysmaticlabs/prysm/v3@v3.1.1/config/params/testnet_ropsten_config.go:30:36: undefined: params.RopstenChainConfig

This PR removes the testnet_ropsten_config.go configuration file together with all ropsten configuration options.

@peterbitfly peterbitfly requested a review from a team as a code owner February 16, 2023 18:08
@peterbitfly peterbitfly changed the title remove support for ropsten testnet Remove support for ropsten testnet Feb 16, 2023
peterbitfly added a commit to gobitfly/eth2-beaconchain-explorer that referenced this pull request Feb 16, 2023
@nisdas
Copy link
Member

nisdas commented Feb 17, 2023

Hey @peterbitfly ,

Thanks for opening this PR, to deprecate the testnet correctly, you will need to add it to the deprecated flags list. For an example of where we do this you can look at:
#10522

@jclapis
Copy link

jclapis commented Feb 24, 2023

I'll add a +1, we just ran into this with the Rocket Pool stack. We're sticking to Geth v1.10.26 and Prysm v3.2.0 until it's resolved.

This was referenced Feb 28, 2023
@nisdas
Copy link
Member

nisdas commented Feb 28, 2023

@peterbitfly I was unable to push the changes to this branch, so I opened a new PR which has them here:
#12058

@nisdas
Copy link
Member

nisdas commented Mar 1, 2023

Closing this PR as #12058 has merged in.

@nisdas nisdas closed this Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants