Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix first bellatrix block when using mev-boost #12019

Merged
merged 6 commits into from
Feb 22, 2023

Conversation

terencechain
Copy link
Member

@terencechain terencechain commented Feb 20, 2023

Caught during e2e test with builder

When requesting a builder block while head is at Altair. The proposer would have packed a nil header block which causes panic during state root transition.

Returning nil is also dangerous, we should return error instead

This would have only affected the first proposed block using mev-boost on bellatrix, we are far passed that point
and luckily that relayer disabled itself until the first Bellatrix finalized checkpoint so we did not encounter this run time

@terencechain terencechain added Bug Something isn't working Builder PR or issue that supports builder related work labels Feb 20, 2023
@terencechain terencechain requested a review from a team as a code owner February 20, 2023 17:07
@terencechain terencechain self-assigned this Feb 20, 2023
@prylabs-bulldozer prylabs-bulldozer bot merged commit da69af9 into develop Feb 22, 2023
@delete-merged-branch delete-merged-branch bot deleted the fix-first-bellatrix-block branch February 22, 2023 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Builder PR or issue that supports builder related work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants