Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update protoc-gen-go-cast to suppress tool output #12062

Merged
merged 3 commits into from
Feb 28, 2023
Merged

Update protoc-gen-go-cast to suppress tool output #12062

merged 3 commits into from
Feb 28, 2023

Conversation

prestonvanloon
Copy link
Member

What type of PR is this?

Other

What does this PR do? Why is it needed?

This uses new changes from protoc-gen-go-cast to suppress unnecessary logging during bazel build.

Removes output like the following:

INFO: From Generating into bazel-out/k8-fastbuild-gcc12/bin/proto/eth/v2/go_proto_/github.com/prysmaticlabs/prysm/v3/proto/eth/v2:                                                       
2023/02/28 19:06:48 grpc
2023/02/28 19:06:48 Casting for 4 extensions: cast_type, ssz_size, ssz_max, spec_name

Which issues(s) does this PR fix?

Other notes for review

@prestonvanloon prestonvanloon requested a review from a team as a code owner February 28, 2023 20:58
@prylabs-bulldozer prylabs-bulldozer bot merged commit 3c73bac into develop Feb 28, 2023
@delete-merged-branch delete-merged-branch bot deleted the update-protoc-gen-go-cast branch February 28, 2023 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terencechain terencechain terencechain approved these changes

@kasey kasey Awaiting requested review from kasey kasey is a code owner automatically assigned from prysmaticlabs/core-team

@nisdas nisdas Awaiting requested review from nisdas nisdas is a code owner automatically assigned from prysmaticlabs/core-team

@james-prysm james-prysm Awaiting requested review from james-prysm james-prysm is a code owner automatically assigned from prysmaticlabs/core-team

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prestonvanloon @terencechain