add mainnet fork epoch #13601
Merged
add mainnet fork epoch #13601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potuz
commented
Feb 9, 2024
potuz
force-pushed
the
deneb_fork_epoch
branch
from
34f6f8e
to
0eee0b1
Compare
|
Tests are failing since we use the consensus_specs repo to verify our configs are correct and we've only updated eth-networks |
|
Waiting for ethereum/consensus-specs#3598 |
prestonvanloon
previously approved these changes
Feb 15, 2024
saolyn
reviewed
Feb 15, 2024
| @@ -23,7 +23,10 @@ const ( | |||
| mainnetAltairForkEpoch = 74240 // Oct 27, 2021, 10:56:23am UTC | |||
| // Bellatrix Fork Epoch for mainnet config. | |||
| mainnetBellatrixForkEpoch = 144896 // Sept 6, 2022, 11:34:47am UTC | |||
| mainnetDenebForkEpoch = math.MaxUint64 | |||
| // Capella Fork Epoch for mainnet config. | |||
| mainnetCapellaForkEpoch = 194048 // April 12, 2023, 22:27:35 UTC | |||
There was a problem hiding this comment.
That being said, for consistency or at least appearing the same as the above comments, it should be:
Suggested change
| mainnetCapellaForkEpoch = 194048 // April 12, 2023, 22:27:35 UTC | |
| mainnetCapellaForkEpoch = 194048 // Apr 12, 2023, 22:27:35pm UTC |
| // Capella Fork Epoch for mainnet config. | ||
| mainnetCapellaForkEpoch = 194048 // April 12, 2023, 22:27:35 UTC | ||
| // Deneb Fork Epoch for mainnet config. | ||
| mainnetDenebForkEpoch = 269568 // March 13, 2024, 13:55:35 UTC |
There was a problem hiding this comment.
Same here:
Suggested change
| mainnetDenebForkEpoch = 269568 // March 13, 2024, 13:55:35 UTC | |
| mainnetDenebForkEpoch = 269568 // Mar 13, 2024, 13:55:35pm UTC |
prestonvanloon
force-pushed
the
deneb_fork_epoch
branch
from
1efc5b0
to
8991773
Compare
prestonvanloon
approved these changes
Feb 16, 2024
terencechain
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blobs are coming.
ethereum/consensus-specs#3597