avoid part path collisions with mem addr entropy #13648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saolyn
reviewed
Feb 21, 2024
kasey
force-pushed
the
avoid-sidecar-truncation
branch
from
bff42a8 to
912b315
Compare
prestonvanloon
previously approved these changes
Feb 21, 2024
kasey
force-pushed
the
avoid-sidecar-truncation
branch
from
912b315 to
0d44e96
Compare
prestonvanloon
force-pushed
the
avoid-sidecar-truncation
branch
from
ae6ae9f to
5f226b9
Compare
prestonvanloon
approved these changes
Feb 21, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
prestonvanloon
pushed a commit
that referenced
this pull request
Feb 21, 2024
* avoid part path collisions with mem addr entropy * Regression test --------- Co-authored-by: Kasey Kirkham <kasey@users.noreply.github.com> Co-authored-by: Preston Van Loon <pvanloon@offchainlabs.com> (cherry picked from commit 4c66e4d)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 7, 2024
* blob save: add better data checking for empty blob issues (#13647) (cherry picked from commit daad29d) * avoid part path collisions with mem addr entropy (#13648) * avoid part path collisions with mem addr entropy * Regression test --------- Co-authored-by: Kasey Kirkham <kasey@users.noreply.github.com> Co-authored-by: Preston Van Loon <pvanloon@offchainlabs.com> (cherry picked from commit 4c66e4d) * fix error race --------- Co-authored-by: Preston Van Loon <pvanloon@offchainlabs.com> Co-authored-by: kasey <489222+kasey@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
We have observed blob sidecars being truncated. My theory is that this is due to a race when 2 of the same blob sidecar are concurrently written and the second calls
Create, which opens the same path withO_TRUNC.