New gossip cache size #13756
Merged
New gossip cache size #13756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Increase seen aggregate cache size to 4096
terencechain
force-pushed
the
new-cache-size
branch
from
763c08e to
a5ab508
Compare
nisdas
approved these changes
Mar 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The aggregated attestation cache size was last updated in 2021. Since then, we have reached the maximum committee count per slot of 64, resulting in 1024 aggregators per slot. Ideally, the number should be lower, but we can receive aggregators across multiple slots. This PR has increased the cache size to 16384. Each entry occupies 16 bytes, so the increase amounts to at least 260kb.
Grafana charts indicate improvements, with a decrease in accepted messages and an increase in rejected messages.
