Return ReadOnlyValidator slice from state and use it when possible
#13782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkapka
commented
Mar 21, 2024
Comment on lines
+182
to
+190
| vals := mv.Value(mv.State()) | ||
| rovals := make([]validator.ReadOnlyValidator, len(vals)) | ||
| var err error | ||
| for i, v := range vals { | ||
| rovals[i], err = validator.NewValidator(v) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| } |
There was a problem hiding this comment.
It takes e few ms to convert 1 million validators, so this extra code is not a big issue
rkapka
force-pushed
the
state-readonlyvals
branch
3 times, most recently
from
e091954 to
0d1e0cc
Compare
rkapka
force-pushed
the
state-readonlyvals
branch
from
0d1e0cc to
da97349
Compare
rkapka
changed the title
ReadOnlyValidator when possibleReadOnlyValidator slice from state and use it when possible
|
Can you quanitfy the advantages of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other
What does this PR do? Why is it needed?
Whenever we need validators from the state, we call
Validators()which returns a copy of the state's validators. But we don't need mutable objects when all we do is perform read operations. Returning a slice ofReadOnlyValidatorwrappers is many times faster and doesn't require making copies.What this PR entails:
ReadOnlyValidators()state method that returns a slice of read only wrappers over the state's validatorsValidators()to the new method whenever possibleconsensus-typesmodule to avoid circular dependencies in some cases