eip-7251: Updated slash_validator #13976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauljordan
reviewed
May 9, 2024
| return nil, errors.Wrap(err, "could not get slashing parameters per version") | ||
| } | ||
|
|
||
| slashingPenalty := validator.EffectiveBalance / slashingQuotient |
There was a problem hiding this comment.
safe math here? just to be careful
There was a problem hiding this comment.
Done in 64dcaa8 for all divisions in this method
Tests for updated slash_validator
prestonvanloon
force-pushed
the
eip-7251-slash-validator
branch
from
9ee3a78 to
64dcaa8
Compare
terencechain
reviewed
May 9, 2024
| ) | ||
|
|
||
| // SlashingParamsPerVersion returns the slashing parameters for the given state version. | ||
| func SlashingParamsPerVersion(v int) (slashingQuotient, proposerRewardQuotient, whistleblowerRewardQuotient uint64, err error) { |
There was a problem hiding this comment.
It could be dangerous if someone messes up the order of the return variables. However, there are more dangerous things out there...
terencechain
approved these changes
May 9, 2024
ErnestK
pushed a commit
to ErnestK/prysm
that referenced
this pull request
May 19, 2024
Tests for updated slash_validator
nisdas
pushed a commit
that referenced
this pull request
Jul 4, 2024
Tests for updated slash_validator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
This PR comes with some minor refactoring.
Part of #13903
Which issues(s) does this PR fix?
Tracking @ #13849
Other notes for review
https://github.com/ethereum/consensus-specs/blob/v1.5.0-alpha.2/specs/electra/beacon-chain.md#updated-slash_validator