Add proposer gRPC suppot for Electra #13984
Conversation
terencechain
force-pushed
the
electra-proposer-rpc
branch
2 times, most recently
from
184dbda to
9c5e532
Compare
terencechain
force-pushed
the
electra-proposer-rpc
branch
from
9c5e532 to
af15381
Compare
| sBlk, err = blocks.NewSignedBeaconBlock(ðpb.SignedBeaconBlockElectra{Block: ðpb.BeaconBlockElectra{Body: ðpb.BeaconBlockBodyElectra{}}}) | ||
| if err != nil { | ||
| return nil, status.Errorf(codes.Internal, "Could not initialize block for proposal: %v", err) | ||
| } |
There was a problem hiding this comment.
I know this is just repeating the existing pattern, but this switch feels upside down. Typically we write this kind of type switch where the inequality is the other way:
bEpoch := slots.ToEpoch(slot)
if bEpoch >= params.BeaconConfig().ElectraForkEpoch {
... // do electra thing
}
if bEpoch >= params.BeaconConfig().DenebForkEpoch {
... // do deneb thing
}
// do phase 0 thing
| @@ -18,6 +18,7 @@ func Test_getEmptyBlock(t *testing.T) { | |||
| config.BellatrixForkEpoch = 2 | |||
| config.CapellaForkEpoch = 3 | |||
| config.DenebForkEpoch = 4 | |||
| config.ElectraForkEpoch = 5 | |||
There was a problem hiding this comment.
Can you document the effect of setting these fork epoch values? I assume the point here is just to set the highest epoch to something that won't overflow (when it is set to max uint) and making sure these epochs don't conflict with each other.
There was a problem hiding this comment.
This is just so we can test the conditions. Here is how it's used in the test case:
slot: primitives.Slot(params.BeaconConfig().ElectraForkEpoch) * params.BeaconConfig().SlotsPerEpoch,
which gets passed to getEmptyBlock(tt.slot), then reached under case epoch >= params.BeaconConfig().ElectraForkEpoch:
terencechain
changed the title
* Add proposer RPC suppot for Electra * Kasey's feedback
* Add proposer RPC suppot for Electra * Kasey's feedback
This PR adds Electra support for proposer RPC. Mainly
GetBlockcan be used to retrieve electra version block to signProposeBlockcan be used to submit electra blockNote to the reviewer:
ProcessOperationsNoVerifyAttsSigsis updated with version.Electra or else unit test will failStreamBlocksResponse