Electra: updated compute_proposer_index
#14153
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestonvanloon
force-pushed
the
electra-updated_compute_proposer_index
branch
from
6f760f8
to
9ebf547
Compare
prestonvanloon
force-pushed
the
electra-updated_compute_proposer_index
branch
from
9ebf547
to
125935b
Compare
terencechain
approved these changes
Jun 28, 2024
| @@ -357,10 +358,11 @@ func BeaconProposerIndexAtSlot(ctx context.Context, state state.ReadOnlyBeaconSt | |||
| // candidate_index = indices[compute_shuffled_index(i % total, total, seed)] | |||
| // random_byte = hash(seed + uint_to_bytes(uint64(i // 32)))[i % 32] | |||
| // effective_balance = state.validators[candidate_index].effective_balance | |||
| // if effective_balance * MAX_RANDOM_BYTE >= MAX_EFFECTIVE_BALANCE * random_byte: | |||
There was a problem hiding this comment.
I think it's fine to not remove this line for pseudocode since implementation still takes maxEB = params.BeaconConfig().MaxEffectiveBalance anyway
There was a problem hiding this comment.
It's not removed, it's modified 1 line down
|
Possible duplicate of #14010 |
|
Closing in favor of #14010 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
ethereum/consensus-specs#3769
Which issues(s) does this PR fix?
Other notes for review